forked from GladysAssistant/Gladys
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat blinking light action #145
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #145 +/- ##
==========================================
+ Coverage 98.30% 98.32% +0.02%
==========================================
Files 833 836 +3
Lines 13176 13292 +116
==========================================
+ Hits 12953 13070 +117
+ Misses 223 222 -1 ☔ View full report in Codecov by Sentry. |
cicoub13
force-pushed
the
feat-blinking-light-action
branch
2 times, most recently
from
January 30, 2024 08:35
730839e
to
794f0ae
Compare
cicoub13
force-pushed
the
feat-blinking-light-action
branch
from
February 5, 2024 20:03
79756a0
to
b3e7de7
Compare
cicoub13
force-pushed
the
feat-blinking-light-action
branch
2 times, most recently
from
February 16, 2024 15:04
1a728fb
to
91c0592
Compare
- Updated sinonjs version to 8.1.1 to benefit from tick.async() - Moved to inline promise with SetTimeout
cicoub13
force-pushed
the
feat-blinking-light-action
branch
from
February 16, 2024 15:08
91c0592
to
bb662ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:
npm test
on both front/server)npm run eslint
on both front/server)npm run prettier
on both front/server)npm run compare-translations
on front)front/src/config/demo.js
) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
Description of change
Please provide a description of the change here. It's always best with screenshots, so don't hesitate to add some!